Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(TextArea): fix content width & height styles #1690

Merged
merged 6 commits into from
Jul 10, 2024
Merged

Conversation

GermanVor
Copy link
Contributor

@GermanVor GermanVor commented Jul 1, 2024

there is no way how to custom height and width of TextArea (not through rows count)

@GermanVor GermanVor requested a review from korvin89 as a code owner July 1, 2024 14:28
@GermanVor GermanVor requested a review from amje July 1, 2024 14:28
@gravity-ui-bot
Copy link
Contributor

Preview is ready.

@gravity-ui-bot
Copy link
Contributor

Visual Tests Report is ready.

@GermanVor
Copy link
Contributor Author

may be it have sense add new property - maxheight for cases height: 100%

@korvin89 korvin89 changed the title chore<TextArea> Custom height and width chore(TextArea): custom height and width Jul 1, 2024
@korvin89
Copy link
Contributor

korvin89 commented Jul 9, 2024

@GermanVor Hey! Could you remove all the tests? We will add them a little bit later

@korvin89 korvin89 changed the title chore(TextArea): custom height and width fix(TextArea): fix content width & height styles Jul 10, 2024
@GermanVor GermanVor merged commit 94979cf into main Jul 10, 2024
7 checks passed
@GermanVor GermanVor deleted the textArea-size branch July 10, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants