-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(Slider): CSF 3 & visual testing #1614
base: main
Are you sure you want to change the base?
Conversation
Preview is ready. |
Playwright Test Component is ready. |
I suggest grouping single and range components in one page for each case. This will help reduce the number of menu items in the showcase section. I think it will be more convenient for watching. |
Agreed, can we write the stories so we have both single and range slider, but with shared controls. |
return ( | ||
<div className={b(null, className)}> | ||
{title && <div className={b('title')}>{title}</div>} | ||
{description && <div className={b('description')}>{description}</div>} | ||
<div className={b('content')}>{children}</div> | ||
<div className={b('content', {isVertical})}>{children}</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added direction
prop in the recent update, you can use it instead
@@ -13,7 +15,7 @@ import type { | |||
interface ComponentFixtures { | |||
mount<HooksConfig extends JsonObject>( | |||
component: JSX.Element, | |||
options?: MountOptions<HooksConfig>, | |||
options?: MountOptions<HooksConfig> & {wrapDivStyles?: React.CSSProperties}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
options?: MountOptions<HooksConfig> & {wrapDivStyles?: React.CSSProperties}, | |
options?: MountOptions<HooksConfig> & {wrapperStyle?: React.CSSProperties}, |
@amje, Maybe we could omit the value property altogether? I don't think it is really necessary for the showcases(excluding the default showcase). UPD: |
@Arucard89 Like this? |
@amje, yes. I believe that it would be helpful for users to play around with the components using the default settings and explore the special, predefined cases. |
No description provided.