Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: enable id-length eslint rule #1607

Closed
wants to merge 2 commits into from
Closed

refactor: enable id-length eslint rule #1607

wants to merge 2 commits into from

Conversation

itwillwork
Copy link
Contributor

No description provided.

@gravity-ui-bot
Copy link
Contributor

Preview is ready.

@gravity-ui-bot
Copy link
Contributor

Playwright Test Component is ready.

korvin89
korvin89 requested changes May 22, 2024
View reviewed changes
Copy link
Contributor

@korvin89 korvin89 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does not look convenient for code supporting. And there are a lot of new eslint-ignores. For example this naming will be look pretty valid:

type Point = {
  x: number;
  y: number;
};

@amje amje changed the title refactor: Id-length eslint rule refactor: enable id-length eslint rule May 22, 2024
@itwillwork itwillwork closed this May 23, 2024
@amje amje deleted the id-length-rule branch July 16, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@korvin89 korvin89 korvin89 requested changes

@NikitaCG NikitaCG Awaiting requested review from NikitaCG NikitaCG is a code owner

@IsaevAlexandr IsaevAlexandr Awaiting requested review from IsaevAlexandr IsaevAlexandr is a code owner

@Raubzeug Raubzeug Awaiting requested review from Raubzeug Raubzeug is a code owner

@Arucard89 Arucard89 Awaiting requested review from Arucard89 Arucard89 is a code owner

@mournfulCoroner mournfulCoroner Awaiting requested review from mournfulCoroner mournfulCoroner is a code owner

@amje amje Awaiting requested review from amje amje is a code owner

@d3m1d0v d3m1d0v Awaiting requested review from d3m1d0v d3m1d0v is a code owner

@ValeraS ValeraS Awaiting requested review from ValeraS ValeraS is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@itwillwork @gravity-ui-bot @korvin89