Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Pagination): add tests #1605

Merged
merged 5 commits into from
May 24, 2024
Merged

chore(Pagination): add tests #1605

merged 5 commits into from
May 24, 2024

Conversation

GermanVor
Copy link
Contributor

@GermanVor GermanVor commented May 22, 2024

No description provided.

@GermanVor GermanVor requested a review from jhoncool as a code owner May 22, 2024 12:05
@gravity-ui-bot
Copy link
Contributor

Preview is ready.

@gravity-ui-bot
Copy link
Contributor

Playwright Test Component is ready.

@jhoncool
Copy link
Contributor

@GermanVor what a problem are you trying to solve here?
total === undefined it's valid case when you can get next page

@GermanVor
Copy link
Contributor Author

@jhoncool
Copy link
Contributor

@jhoncool

https://t.me/gravity_ui_chat/1624

It's not a bug. It's by design

@GermanVor GermanVor changed the title chore(Pagination): total property undefined disable next chore(Pagination): add tests May 23, 2024
@GermanVor
Copy link
Contributor Author

@jhoncool 1f68b21

Change PR name

@GermanVor GermanVor merged commit e35ce8b into main May 24, 2024
5 checks passed
@GermanVor GermanVor deleted the pagination-total branch May 24, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants