fix(Button): do not shrink button when there is only one icon #1577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview is ready. |
|
Playwright Test Component is ready. |
|
@teleginzhenya Could you add test for this case? |
teleginzhenya
force-pushed
the
feature/fix-only-icon-button-shrink
branch
from
3dec613 to
bd38edc
Compare
korvin89
approved these changes
May 13, 2024
amje
requested changes
May 14, 2024
src/components/Button/Button.scss
Outdated
| @@ -34,6 +34,7 @@ $block: '.#{variables.$ns}button'; | |||
| color 0.15s linear; | |||
| transform: scale(1); | |||
| display: inline-flex; | |||
| flex-shrink: 0; | |||
There was a problem hiding this comment.
That's not the cause of the problem. The problem is in the negative margins of .g-button__icon element. Setting flex-shrink to 0 would break user layouts relying on flex
amje
approved these changes
May 16, 2024
teleginzhenya
force-pushed
the
feature/fix-only-icon-button-shrink
branch
from
9047cd0 to
52889cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resetting plugin makes button with only icon shrink (#1529). Started to happen after flex refactoring (#1452)
Related issue #1529