feat: added a hook for generating a unique color #1565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Playwright Test Component is ready. |
|
Preview is ready. |
amje
requested changes
May 6, 2024
amje
requested changes
May 15, 2024
src/hooks/useColorGenerator/__stories__/useColorGenerator.stories.tsx
Outdated
Show resolved
Hide resolved
amje
requested changes
Jun 4, 2024
src/hooks/useColorGenerator/__stories__/useColorGenerator.stories.tsx
Outdated
Show resolved
Hide resolved
src/hooks/useColorGenerator/__stories__/useColorGenerator.stories.tsx
Outdated
Show resolved
Hide resolved
|
Visual Tests Report is ready. |
amje
requested changes
Jun 6, 2024
| | token | Unique attribute of the entity (e.g., name, id, email) | `string` | | | | | ||
| | colorKeys | If an array of colors is passed, an index is generated from the token passed, and the value from the color array at that index is returned | `string[]` | | | | | ||
| | Name | Description | Type | Default | | | | ||
| | :-------- | :----------------------------------------------------- | :----------------------- | :-----: | --- | --- | |
There was a problem hiding this comment.
Type column should also be centered. Also markdown seems broken.
| ...props, | ||
| theme, | ||
| }), | ||
| [props, theme], |
There was a problem hiding this comment.
props is an object, better to pass individual props
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.