feat(Sheet): add aria attributes #1555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview is ready. |
|
Playwright Test Component is ready. |
mournfulCoroner
changed the title
amje
requested changes
Apr 27, 2024
| <div | ||
| ref={this.veilRef} | ||
| className={sheetBlock('veil', veilTransitionMod)} | ||
| onClick={isAnimating ? undefined : this.onVeilClick} | ||
| onTransitionEnd={this.onVeilTransitionEnd} | ||
| role="presentation" |
There was a problem hiding this comment.
There is no need to specify this. div has no semantics, and hasn't contain any children
There was a problem hiding this comment.
Thank you for information!
But I don't know how to avoid eslint-disable-next-line jsx-a11y/click-events-have-key-events because this div must be clickable. Maybe I could rewrite the component as a functional and use the useLayer instead of the usual handler? I also think it would be nice to add FocusTrap to the sheet content
amje
approved these changes
Apr 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#690