fix(theme): add option for controlling :root color-scheme #1468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview is ready. |
|
Playwright Test Component is ready. |
korvin89
approved these changes
Apr 10, 2024
korvin89
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Curently UIKit provides custom scrollbars by default that can be disabled using nativeScrollbar option on the ThemeProvider.
However, on Chrome-based browsers on Windows, native scrollbars appear white even when dark mode on the body is enabled (and setting
color-scheme: darkon the body tag does not help).Example
To get proper dark scrollbars we need to set
color-scheme: darkon the:rootelement (html tag). GitHub itself, for example, is doing exactly that.This PR adds color-scheme styling to
:root(but this new styles only apply when uikit theme is not scoped).Examples with color-scheme on :root