refactor(styles): set CSS vars in pin mixin
#1296
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Playwright Test Component is ready. |
|
Preview is ready. |
amje
requested changes
Apr 27, 2024
ogonkov
force-pushed
the
refactor/pin_vars
branch
from
e033e64 to
d578050
Compare
amje
requested changes
Jun 3, 2024
Comment on lines
+87
to
+90
| var(#{$-pin-mixin-variables-ns}-top-left) | ||
| var(#{$-pin-mixin-variables-ns}-top-right) | ||
| var(#{$-pin-mixin-variables-ns}-bottom-right) | ||
| var(#{$-pin-mixin-variables-ns}-bottom-left) |
There was a problem hiding this comment.
physical properties instead of logical ones
There was a problem hiding this comment.
But property is border-radius, it is rtl compatible
There was a problem hiding this comment.
There should be no such api like top-left, bottom-right. Instead we should only use logical names: start-start, end-end, etc.
There was a problem hiding this comment.
Oh, i will rename vars, no problem
| @each $selector in $selectors { | ||
| &#{get-pin-selector(#{$block}_pin_round-round, $selector, $append)} { | ||
| border-radius: $radius; | ||
| @include -pin-mixin-variables-from-list($radius); |
There was a problem hiding this comment.
This would break customization via CSS API, see "Custom" story of Button
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will set CSS-vars in private namespace, that will allow to developer reuse
border-radiusin children elements, for example to match nested elementborder-radiusby reducing it viacalc().