Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(Table): added unit tests to Table components #1294

Merged
merged 2 commits into from
Feb 2, 2024
Merged

test(Table): added unit tests to Table components #1294

merged 2 commits into from
Feb 2, 2024

Conversation

kkirik
Copy link
Contributor

@kkirik kkirik commented Jan 31, 2024

Closes #1080

@gravity-ui-bot
Copy link
Contributor

Playwright Test Component is ready.

@gravity-ui-bot
Copy link
Contributor

Preview is ready.

@korvin89 korvin89 requested a review from Raubzeug January 31, 2024 16:12
@korvin89
Copy link
Contributor

@kkirik @Raubzeug
I suggest to exclude snapshot tests, we already have React-Testing-Library and Playwright, I suppose that's enough

@korvin89 korvin89 merged commit 1c6ece6 into main Feb 2, 2024
4 checks passed
@korvin89 korvin89 deleted the feat/table-tests branch February 2, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Raubzeug Raubzeug Raubzeug approved these changes

@korvin89 korvin89 korvin89 approved these changes

@amje amje Awaiting requested review from amje

@ValeraS ValeraS Awaiting requested review from ValeraS

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move Table tests from internal repo
4 participants
@kkirik @gravity-ui-bot @korvin89 @Raubzeug