Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Select): added errorMessage, errorPlacement and validationType props #1291

Merged
merged 7 commits into from
Jan 31, 2024
Merged

feat(Select): added errorMessage, errorPlacement and validationType props #1291

merged 7 commits into from
Jan 31, 2024

Conversation

kkirik
Copy link
Contributor

@kkirik kkirik commented Jan 30, 2024

Closes #1273

@kkirik kkirik requested a review from korvin89 as a code owner January 30, 2024 16:43
@kkirik kkirik force-pushed the feat/select-errors branch from 87f3dcb to d40aff7 Compare January 30, 2024 16:44
@gravity-ui-bot
Copy link
Contributor

Preview is ready.

@gravity-ui-bot
Copy link
Contributor

Playwright Test Component is ready.

@korvin89
Copy link
Contributor

One more thing: could u add some tests for this features? U can get tests from here. And add QA constant here please. And there is some different behaviour regarding TextInput (in this test case, but it has a confusing name :))

@kkirik kkirik force-pushed the feat/select-errors branch from 4811cae to 195886b Compare January 31, 2024 14:17
@kkirik
Copy link
Contributor Author

kkirik commented Jan 31, 2024

One more thing: could u add some tests for this features? U can get tests from here. And add QA constant here please. And there is some different behaviour regarding TextInput (in this test case, but it has a confusing name :))

So, I added some tests for error feature also I added an aria-label attribute for getting internal error icon by i11y attributes.

@kkirik kkirik force-pushed the feat/select-errors branch from 195886b to 6e33a2c Compare January 31, 2024 14:26
@kkirik kkirik merged commit 8f2f07b into main Jan 31, 2024
4 checks passed
@kkirik kkirik deleted the feat/select-errors branch January 31, 2024 14:54
@gravity-ui-bot gravity-ui-bot mentioned this pull request Jan 31, 2024
Merged
@gravity-ui-bot gravity-ui-bot mentioned this pull request Feb 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@korvin89 korvin89 korvin89 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Select: add error view like in TextInput component
3 participants
@kkirik @gravity-ui-bot @korvin89