Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(List): calling onLoadMore function while using keyboard #1284

Merged
merged 2 commits into from
Jan 30, 2024
Merged

fix(List): calling onLoadMore function while using keyboard #1284

merged 2 commits into from
Jan 30, 2024

Conversation

kkirik
Copy link
Contributor

@kkirik kkirik commented Jan 29, 2024

Closes #1105

@kkirik kkirik requested a review from korvin89 as a code owner January 29, 2024 16:36
@kkirik kkirik force-pushed the fix/list-new-items branch from 7cf5d77 to 147fff3 Compare January 29, 2024 16:37
@gravity-ui-bot
Copy link
Contributor

Playwright Test Component is ready.

@gravity-ui-bot
Copy link
Contributor

Preview is ready.

korvin89
korvin89 reviewed Jan 30, 2024
View reviewed changes
Copy link
Contributor

@korvin89 korvin89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could u add height to main container to avoid such situation?

Screen.Recording.2024-01-30.at.10.51.17.mov

@kkirik
Copy link
Contributor Author

kkirik commented Jan 30, 2024

Could u add height to main container to avoid such situation?

Screen.Recording.2024-01-30.at.10.51.17.mov

Done

@kkirik kkirik merged commit 1760166 into main Jan 30, 2024
4 checks passed
@kkirik kkirik deleted the fix/list-new-items branch January 30, 2024 13:26
@gravity-ui-bot gravity-ui-bot mentioned this pull request Jan 30, 2024
Merged
@gravity-ui-bot gravity-ui-bot mentioned this pull request Feb 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@korvin89 korvin89 korvin89 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

List: Call OnLoadMore when navigating from the keyboard
3 participants
@kkirik @gravity-ui-bot @korvin89