feat: separate useControlledState hook #1267
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Alexandr Isaev <[email protected]>
IsaevAlexandr
force-pushed
the
feature-separate-controlled-state-hook
branch
from
6638803 to
788c002
Compare
|
Preview is ready. |
|
also here I think it's a simple hook that will be regularly used while developing library components |
GermanVor
reviewed
Jan 22, 2024
| const [state, setState] = React.useState(value ?? defaultValue); | ||
|
|
||
| return [ | ||
| value || state, |
|
@IsaevAlexandr @amje @korvin89 Ping |
|
@IsaevAlexandr Hey! We already have this one. Could we use your hook instead of date-components hook? |
|
@IsaevAlexandr @korvin89 Seems the same functionality is implemented in #1276 |
IsaevAlexandr
requested review from
NikitaCG,
imechoim,
ogonkov,
resure,
sofiushko,
Raubzeug,
zamkovskaya,
SeqviriouM,
mournfulCoroner,
DakEnviy,
Lunory,
kseniya57,
jhoncool,
LakeVostok,
goshander and
axtk
as code owners
|
This functionality have added here #1276 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@GermanVor related to #1090 (comment).
I'm not sure if this functionality is needed or not. I make this proposal to discuss