feat(TextInput/TextArea): prevent zoom on iOS #1238
Conversation
|
Playwright Test Component is ready. |
|
Preview is ready. |
| @@ -1 +1,4 @@ | |||
| $border-width: 1px; | |||
| // Safari on iOS zoom page if input font-size is smaller than 16px | |||
| // https://css-tricks.com/16px-or-larger-text-prevents-ios-form-zoom/ | |||
| $mobile-safari-font-size: 16px; | |||
There was a problem hiding this comment.
I suggest u to rename this to $mobile-font-size case of it uses not only for safari styles
There was a problem hiding this comment.
May be $mobile-min-font-size then?
There was a problem hiding this comment.
But we do not have a max size or other size at all
There was a problem hiding this comment.
But we do have minimal size, it's not just any mobile font size, it is a minimal possible size for Safari
There was a problem hiding this comment.
ok. It's not a public api
| @@ -9,6 +10,10 @@ $block: '.#{variables.$ns-new}text-area'; | |||
| width: 100%; | |||
| position: relative; | |||
|
|
|||
| &_mobile { | |||
| font-size: control-variables.$mobile-safari-font-size; | |||
There was a problem hiding this comment.
Not sure if it's a good idea to hardcode 16px for all the sizes in mobile devices
There was a problem hiding this comment.
It's really annoying bug. Why not?
Do you know better? |
Revise font sizes in all components for l/xl size to be at least 16px. But it's cannot be done right away, we need some time to think about it |
No description provided.