feat(Table)!: remove uppercase heading style #1222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArturAbdullin
requested review from
resure,
amje,
ogonkov,
korvin89,
IsaevAlexandr,
sofiushko,
zamkovskaya,
SeqviriouM,
mournfulCoroner,
DaffPunks,
Lunory,
kseniya57,
jhoncool,
NikitaCG,
LakeVostok,
goshander,
axtk,
Raubzeug and
ValeraS
as code owners
|
Preview is ready. |
|
Playwright Test Component is ready. |
|
May be we can do it via option, like |
|
Oh, this is for next major, ok |
amje
approved these changes
Dec 25, 2023
Raubzeug
approved these changes
Dec 25, 2023
amje
pushed a commit
that referenced
this pull request
Feb 1, 2024
amje
pushed a commit
that referenced
this pull request
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: for now, there is no clean way to give the title to the column with lower case first letter, like
vCPUfor instance.Solution: Removed the uppercase transform for the first letter of the header cell. The property is uncontrollable and when removed can be easily reproduced in more controllable way with the text itself.