Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: update avatar and user components #1221

Merged
merged 1 commit into from
Dec 27, 2023
Merged

feat!: update avatar and user components #1221

merged 1 commit into from
Dec 27, 2023

Conversation

DakEnviy
Copy link
Contributor

No description provided.

@gravity-ui-bot
Copy link
Contributor

Preview is ready.

@gravity-ui-bot
Copy link
Contributor

Playwright Test Component is ready.

@DakEnviy DakEnviy requested a review from goshander as a code owner December 22, 2023 17:04
@DakEnviy DakEnviy force-pushed the feat/new-avatar branch 7 times, most recently from 07895bd to 8547906 Compare December 22, 2023 19:55
@DakEnviy DakEnviy removed the request for review from goshander December 22, 2023 19:55
src/components/Avatar/Avatar.scss Outdated Show resolved Hide resolved
src/components/Avatar/Avatar.scss Outdated Show resolved Hide resolved
src/components/Avatar/Avatar.tsx Outdated Show resolved Hide resolved
src/components/Avatar/Avatar.tsx Show resolved Hide resolved
src/components/Avatar/types/main.ts Outdated Show resolved Hide resolved
src/components/PersonaWrap/PersonaWrap.scss Outdated Show resolved Hide resolved
src/components/User/README.md Outdated Show resolved Hide resolved
src/components/User/User.tsx Outdated Show resolved Hide resolved
src/components/UserWrapper/UserWrapper.tsx Outdated Show resolved Hide resolved
@DakEnviy DakEnviy changed the base branch from main to next December 25, 2023 13:40
@DakEnviy DakEnviy force-pushed the feat/new-avatar branch 5 times, most recently from 0b0ba33 to 3f30b1d Compare December 25, 2023 16:02
src/components/Avatar/Avatar.tsx Outdated Show resolved Hide resolved
src/components/Avatar/types/main.ts Show resolved Hide resolved
#{$block}_clickable:hover & {
background-color: var(--g-color-base-generic);
}
#{$blockAvatar} {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to specify inner selector, we can put these vars inside &__avatar

src/components/User/User.tsx Outdated Show resolved Hide resolved
@DakEnviy DakEnviy force-pushed the feat/new-avatar branch 3 times, most recently from 2a7942b to 2225819 Compare December 25, 2023 17:00
@DakEnviy DakEnviy force-pushed the feat/new-avatar branch 4 times, most recently from f100a09 to 966a8d8 Compare December 26, 2023 16:03
@amje amje changed the title feat: update avatar and user components feat!: update avatar and user components Dec 27, 2023
@amje amje merged commit e9996ce into next Dec 27, 2023
4 checks passed
@amje amje deleted the feat/new-avatar branch December 27, 2023 15:48
amje pushed a commit that referenced this pull request Feb 1, 2024
amje pushed a commit that referenced this pull request Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants