feat: add Table footer #1146
Closed
feat: add Table footer #1146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview is ready. |
|
Playwright Test Component is ready. |
amje
requested changes
Nov 21, 2023
src/components/Table/Table.tsx
Outdated
| @@ -106,6 +106,8 @@ export interface TableProps<I> extends QAProps { | |||
| className?: string; | |||
| /** Adds horizontal padding for edge cells. */ | |||
| edgePadding?: boolean; | |||
| /** Display footer inside the table container */ | |||
| renderFooter?: () => React.ReactElement | undefined; | |||
There was a problem hiding this comment.
React.ReactNode is more usable type here, it allows raw strings
There was a problem hiding this comment.
But now I see a deeper problem here. Users may misunderstand that this property refers to the table footer (aka tfoot element). And I don't know how avoid that problem. Maybe we should rename the property?
| @@ -106,6 +106,8 @@ export interface TableProps<I> extends QAProps { | |||
| className?: string; | |||
| /** Adds horizontal padding for edge cells. */ | |||
| edgePadding?: boolean; | |||
| /** Display footer inside the table container */ | |||
krozhkov
force-pushed
the
yarozhkov/feat-table-add-footer
branch
from
8e74677 to
aa2d309
Compare
krozhkov
force-pushed
the
yarozhkov/feat-table-add-footer
branch
from
aa2d309 to
c2367d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.