fix(Select): add [type="button"] to control node (#762)

Co-authored-by: yymoroz3 <[email protected]>
gravity-ui · Jun 23, 2023 · adc01f0 · adc01f0
1 parent c113920
commit adc01f0
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/src/components/Select/__tests__/Select.base-actions.test.tsx b/src/components/Select/__tests__/Select.base-actions.test.tsx
@@ -63,6 +63,13 @@ describe('Select base actions', () => {
             expect(selectControl).not.toHaveClass(SELECT_CONTROL_OPEN_CLASS);
             expect(screen.queryByTestId(SelectQa.POPUP)).toBeNull();
         });
+        test('should have [type="button"] attribute in root button', async () => {
+            await act(async () => {
+                setup();
+            });
+            const selectControl = screen.getByTestId(TEST_QA);
+            expect(selectControl).toHaveAttribute('type', 'button');
+        });
     });
 
     describe('open', () => {

diff --git a/src/components/Select/components/SelectControl/SelectControl.tsx b/src/components/Select/components/SelectControl/SelectControl.tsx
@@ -76,6 +76,7 @@ export const SelectControl = React.forwardRef<HTMLElement, ControlProps>((props,
                 disabled={disabled}
                 onClick={toggleOpen}
                 onKeyDown={onKeyDown}
+                type="button"
             >
                 {label && <span className={selectControlBlock('label')}>{label}</span>}
                 {showPlaceholder && (