chore: adjusting state on prop change in an Effect

gravity-ui · Feb 11, 2024 · 504d856 · 504d856
1 parent 7a53e94
commit 504d856
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/src/components/Table/hoc/withTableSettings/TableColumnSetup/TableColumnSetup.tsx b/src/components/Table/hoc/withTableSettings/TableColumnSetup/TableColumnSetup.tsx
@@ -69,10 +69,13 @@ export const TableColumnSetup = (props: TableColumnSetupProps) => {
 
     const [items, setItems] = React.useState(prepareItems(propsItems));
 
-    React.useEffect(() => {
+    const [prevPropsItems, setPrevPropsItems] = React.useState(propsItems);
+    if (propsItems !== prevPropsItems) {
+        setPrevPropsItems(propsItems);
+
         const newItems = prepareItems(propsItems);
         setItems(newItems);
-    }, [propsItems]);
+    }
 
     const onApply = () => {
         const newSettings = items.map<TableSetting>(({id, isSelected}) => ({id, isSelected}));