Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: replace html-button to Button-component from uikit #990

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: replace html-button to Button-component from uikit #990

wants to merge 3 commits into from

Conversation

JeikZim
Copy link
Contributor

@JeikZim JeikZim commented Aug 19, 2024

No description provided.

@JeikZim JeikZim changed the title refactor: replace <button> to <Button> from uikit refactor: replace html-button to Button-component from uikit Aug 19, 2024
@NikitaCG
Copy link
Collaborator

@JeikZim please rename this PR like feat:

@gravity-ui-bot
Copy link
Contributor

Playwright Test Component is ready.

@JeikZim JeikZim changed the title refactor: replace html-button to Button-component from uikit feat: replace html-button to Button-component from uikit Aug 20, 2024
@gravity-ui-bot
Copy link
Contributor

Preview is ready.

NikitaCG
NikitaCG requested changes Sep 12, 2024
View reviewed changes
Copy link
Collaborator

@NikitaCG NikitaCG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/gravity-ui/uikit/blob/main/src/components/Button/Button.scss
Control sizes are not equal uikit Button sizes

@JeikZim
Copy link
Contributor Author

JeikZim commented Sep 30, 2024

https://github.com/gravity-ui/uikit/blob/main/src/components/Button/Button.scss Control sizes are not equal uikit Button sizes

It really is. However, is this a problem? This component is used only in one place (in MobileMenuButton), and there it has an "l" value equal to this value in uikit

@JeikZim JeikZim requested a review from NikitaCG September 30, 2024 20:28
@NikitaCG
Copy link
Collaborator

https://github.com/gravity-ui/uikit/blob/main/src/components/Button/Button.scss Control sizes are not equal uikit Button sizes

It really is. However, is this a problem? This component is used only in one place (in MobileMenuButton), and there it has an "l" value equal to this value in uikit

Yes, it's problem because it's breaking change for our users

We are need to release it in major version and receive 'ok' from design

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gorgeousvlad gorgeousvlad Awaiting requested review from gorgeousvlad gorgeousvlad is a code owner

@NikitaCG NikitaCG Awaiting requested review from NikitaCG NikitaCG is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JeikZim @NikitaCG @gravity-ui-bot