feat: add standalone navigation #693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview is ready. |
| @@ -21,7 +22,7 @@ const NavigationItem: React.FC<NavigationItemProps> = ({ | |||
| ...props | |||
| }: NavigationItemProps) => { | |||
| const {type = NavigationItemType.Link} = data; | |||
| const {navItemMap} = useContext(InnerContext); | |||
| const navItemMap = useNavItemMap(); | |||
There was a problem hiding this comment.
Just a suggestion:
Suggested change
| const navItemMap = useNavItemMap(); | |
| const navItemMap = useNavigationItemMap(); |
|
|
||
| import Navigation, {NavigationProps} from './../../components/Navigation/Navigation'; | ||
|
|
||
| const Standalone = (props: NavigationProps) => ( |
There was a problem hiding this comment.
Why is const exists and its name Standalone?
There was a problem hiding this comment.
I called it so because you can import and use this Navigation component regardless of constructor itself
This case requires an addition of g-root class to parent , thats why this component exists
There was a problem hiding this comment.
Can you add to readme the example of how to import navigation and use it with theme please?
yuberdysheva
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.