Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added description field to companies block #692

Merged
merged 7 commits into from
Nov 15, 2023

Conversation

VitaliiDC8
Copy link
Contributor

No description provided.

@gravity-ui-bot
Copy link
Contributor

Preview is ready.

src/blocks/Companies/Companies.tsx Outdated Show resolved Hide resolved
@yuberdysheva
Copy link
Contributor

  1. You have to add this block to text-transform config to support yfm in description field. I suggest also to support typograph in title. Please use this example of CardLayoutBlock: https://github.com/gravity-ui/page-constructor/blob/main/src/text-transform/config.ts#L362
  2. Let's add the second example to storybook with description

WithDescription.args = {
...data.default.content,
description:
'<p><strong>Ut enim ad minim veniam</strong> <a href="https://example.com">quis nostrud</a> exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.</p>\n',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

@VitaliiDC8 VitaliiDC8 merged commit f305732 into main Nov 15, 2023
3 checks passed
@VitaliiDC8 VitaliiDC8 deleted the feat/add-description-to-companies branch November 15, 2023 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants