add new view for Table and fix design bugs #622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview is ready. |
Lakate
commented
Oct 6, 2023
|
Could you please add a new type of table to the storybook? Didn't find it there |
yuberdysheva
suggested changes
Oct 6, 2023
| <div className={b(null, className)} style={style} data-qa={qa || qaIdByDefault}> | ||
| <div | ||
| className={b(null, className)} | ||
| style={{...style, backgroundColor: 'transparent'}} |
There was a problem hiding this comment.
why did you set backgroundColor here but not in css-file?
There was a problem hiding this comment.
because styles from html have higher specific than styles in css
https://preview.gravity-ui.com/page-constructor/622/?path=/story/blocks-table--tick |
yuberdysheva
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in prod:
in beta:
