test(Image): test for Image added #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview is ready. |
yuberdysheva
suggested changes
May 31, 2023
src/components/BackgroundImage/__tests__/BackgroundImage.test.tsx
Outdated
Show resolved
Hide resolved
yuberdysheva
suggested changes
Jun 14, 2023
src/components/Image/Image.tsx
Outdated
| )} | ||
| <source srcSet={mobile} media={`(max-width: ${BREAKPOINTS.sm}px)`} /> | ||
| </Fragment> | ||
| <DeviceSpecificFragment src={mobile} disableWebp={disableWebp} breakpoint="sm" /> |
There was a problem hiding this comment.
Suggested change
| <DeviceSpecificFragment src={mobile} disableWebp={disableWebp} breakpoint="sm" /> | |
| <DeviceSpecificFragment src={mobile} disableWebp={disableWebp} breakpoint="BREAKPOINTS.sm" /> |
There was a problem hiding this comment.
There was a problem hiding this comment.
Why are we using it inside when we can pass it from here once?
|
#401 separeted |
niktverd
force-pushed
the
test/image
branch
2 times, most recently
from
a2656f5 to
32491b8
Compare
niktverd
force-pushed
the
test/image
branch
from
32491b8 to
d520fba
Compare
niktverd
force-pushed
the
test/image
branch
from
d520fba to
591aeed
Compare
src/components/Image/Image.tsx
Outdated
| data-qa={`${qa}-compressed`} | ||
| /> | ||
| )} | ||
| <source srcSet={src} media={`(max-width: ${BREAKPOINTS[breakpoint]}px)`} data-qa={qa} /> |
There was a problem hiding this comment.
Suggested change
| <source srcSet={src} media={`(max-width: ${BREAKPOINTS[breakpoint]}px)`} data-qa={qa} /> | |
| <source srcSet={src} media={`(max-width: breakpoint)`} data-qa={qa} /> |
There was a problem hiding this comment.
I hope I understand you
src/components/Image/Image.tsx
Outdated
| @@ -37,11 +37,11 @@ const DeviceSpecificFragment = ({ | |||
| <source | |||
| srcSet={checkWebP(src)} | |||
| type="image/webp" | |||
| media={`(max-width: ${BREAKPOINTS[breakpoint]}px)`} | |||
| media={`(max-width: ${breakpoint})`} | |||
There was a problem hiding this comment.
Let's put px here inside and remove extra parenthesis
media={(max-width: ${breakpoint}px}
yuberdysheva
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.