fix: remove loading default font #1078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Playwright Test Component is ready. |
|
Preview is ready. |
|
breaking changes |
change target branch on next |
NikitaCG
reviewed
Nov 15, 2024
package.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "@gravity-ui/page-constructor", | |||
| "version": "5.30.0", | |||
| "version": "5.30.0-alpha.0", | |||
NikitaCG
requested changes
Nov 15, 2024
README.md
Outdated
| To use default font, add import in your file: | ||
|
|
||
| ```css | ||
| @import '@gravity-ui/uikit/styles/fonts.css'; |
There was a problem hiding this comment.
Shouldn't we make a font file in a PC and provide it for import to our users? What do you think?
There was a problem hiding this comment.
Do you mean that need add fonts.css file in page-constructor and import it file instead of fonts.css from uikit?
aeksandla
force-pushed
the
aeksandla/remove-default-font
branch
from
1000ed1 to
edb9a9a
Compare
aeksandla
force-pushed
the
aeksandla/remove-default-font
branch
from
edb9a9a to
c028fc2
Compare
NikitaCG
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.