Skip to content

Commit

Permalink
fix: extraProps handling correctly (#699)
Browse files Browse the repository at this point in the history
  • Loading branch information
Kyzyl-ool authored Nov 16, 2023
1 parent beb78e0 commit 349623c
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 1 deletion.
1 change: 1 addition & 0 deletions src/blocks/Header/Header.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,7 @@ export const HeaderBlock = (props: WithChildren<HeaderBlockFullProps>) => {
size="xl"
extraProps={{
'aria-describedby': titleId,
...button.extraProps,
}}
{...button}
/>
Expand Down
2 changes: 1 addition & 1 deletion src/models/constructor-items/blocks.ts
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ export interface HeaderBlockProps {
title: string;
overtitle?: string;
description?: string;
buttons?: Pick<ButtonProps, 'url' | 'text' | 'theme' | 'primary' | 'size'>[];
buttons?: Pick<ButtonProps, 'url' | 'text' | 'theme' | 'primary' | 'size' | 'extraProps'>[];
width?: HeaderWidth;
/** @deprecated imageSize now depends on width */
imageSize?: HeaderImageSize;
Expand Down
2 changes: 2 additions & 0 deletions src/sub-blocks/Content/Content.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,7 @@ const Content = (props: ContentProps) => {
qa={qaAttributes.link}
extraProps={{
'aria-describedby': link.urlTitle ? undefined : titleId,
...link.extraProps,
}}
/>
))}
Expand All @@ -140,6 +141,7 @@ const Content = (props: ContentProps) => {
qa={qaAttributes.button}
extraProps={{
'aria-describedby': item.urlTitle ? undefined : titleId,
...item.extraProps,
}}
/>
))}
Expand Down

0 comments on commit 349623c

Please sign in to comment.