-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(AsideHeader): preventUserRemoving prop for menu item and callbacks for AsideHeader #314
Merged
jenshenJ
merged 9 commits into
main
from
feat/add-calbacks-and-prevent-user-removing-prop
Oct 8, 2024
Merged
feat(AsideHeader): preventUserRemoving prop for menu item and callbacks for AsideHeader #314
jenshenJ
merged 9 commits into
main
from
feat/add-calbacks-and-prevent-user-removing-prop
Oct 8, 2024
+20
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenshenJ
requested review from
DarkGenius,
Lunory and
sunduckcow
as code owners
September 30, 2024 21:18
Preview is ready. |
Playwright Test Component is ready. |
DarkGenius
reviewed
Oct 2, 2024
DarkGenius
requested changes
Oct 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments
DarkGenius
approved these changes
Oct 8, 2024
benax-se
pushed a commit
that referenced
this pull request
Nov 12, 2024
…ks for AsideHeader (#314) * feat: add preventUserRemoving prop for menu item and add callbacks for aside header
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.