feat(HotkeysPanel): improve hotkeys panel docs #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kseniya57
commented
Sep 25, 2024
kseniya57
commented
- Improve hotkeys panel docs
- remove extra block for landing
- add some customization props
kseniya57
requested review from
DarkGenius,
Lunory and
sunduckcow
as code owners
|
Preview is ready. |
|
Playwright Test Component is ready. |
DarkGenius
reviewed
Sep 25, 2024
| | title | `Array` | | | The panel title | | ||
| | visible | `Boolean` | yes | | Whether drawer visible or not | | ||
| | onClose | `Function` | | | Close drawer handler | | ||
| | filterable | `Boolean` | yes | | Whether show search input or not | |
There was a problem hiding this comment.
Is this a required prop? The type is defined as optional with a default value
kseniya57
force-pushed
the
hotkeys-panel-improvements-and-docs
branch
from
0052991 to
f49c90b
Compare
kseniya57
force-pushed
the
hotkeys-panel-improvements-and-docs
branch
from
f49c90b to
03b3bb9
Compare
kseniya57
force-pushed
the
hotkeys-panel-improvements-and-docs
branch
from
03b3bb9 to
0daa4a8
Compare
DarkGenius
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.