Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Drawer): change disablePortal default value #274

Merged
merged 1 commit into from
Jul 22, 2024
Merged

fix(Drawer): change disablePortal default value #274

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/Drawer/Drawer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ export const Drawer: React.FC<DrawerProps> = ({
onEscape,
preventScrollBody = true,
hideVeil,
disablePortal,
disablePortal = true,
}) => {
let someItemVisible = false;
React.Children.forEach(children, (child) => {
Expand Down
2 changes: 1 addition & 1 deletion src/components/Drawer/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ The Drawer module consists of two primary components: `Drawer` and `DrawerItem`.
| onVeilClick | Optional callback function that is called when the veil (overlay) is clicked. | `(event: React.MouseEvent) => void` | |
| onEscape | Optional callback function that is called when the escape key is pressed, if the drawer is open. | `() => void` | |
| hideVeil | Optional flag to hide the background darkening | `boolean` | |
| disablePortal | Optional flag to not render drawer inside `Portal` | `boolean` | |
| disablePortal | Optional flag to not render drawer inside `Portal` | `boolean` | `true` |

## CSS API

Expand Down
Loading