Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: updated vertical divider #144

Merged
merged 2 commits into from
Nov 10, 2023
Merged

feat: updated vertical divider #144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e17ca1c
feat: updated vertical divider
Nov 10, 2023
449badb
fix: updated readme
Nov 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,4 +72,4 @@ Used for themization Navigation's components
| `--gn-aside-header-footer-item-icon-color` | | `--g-color-text-primary` |
| `--gn-aside-header-subheader-item-icon-color` | | `--g-color-text-primary` |
| `--gn-aside-header-item-icon-background-size` | Background size used when `AsideHeader` is compact | `38px` |
| `--gn-aside-header-divider-line-color` | Vertical color divider between `AsideHeader` and content | Light theme: `transparent`, Dark theme: `--g-color-line-generic-solid` |
| `--gn-aside-header-divider-line-color` | Vertical color divider between `AsideHeader` and content | Light theme: `--g-color-line-generic`, Dark theme: `--g-color-line-generic-solid` |
12 changes: 1 addition & 11 deletions src/components/AsideHeader/AsideHeader.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ $block: '.#{variables.$ns}aside-header';

.g-root_theme_light,
.g-root_theme_light-hc {
--gn-aside-header-divider-line-color: transparent;
--gn-aside-header-divider-line-color: var(--g-color-line-generic);
--gn-aside-header-subheader-divider-line-color: var(--g-color-line-generic);
}

Expand Down Expand Up @@ -78,16 +78,6 @@ $block: '.#{variables.$ns}aside-header';
z-index: 2;
user-select: none;

&::after {
position: absolute;
top: 0;
right: -100px;
bottom: 0;
width: 100px;
content: '';
box-shadow: 0px 0px 4px rgba(0, 0, 0, 0.1), 0px 0px 24px rgba(0, 0, 0, 0.08);
}

& > #{$class}-logo {
margin: 8px 0;
}
Expand Down
Loading