Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: split AsideHeader to compound components #140

Merged
merged 12 commits into from
Nov 3, 2023

Conversation

ldrv565
Copy link
Contributor

@ldrv565 ldrv565 commented Oct 23, 2023

according to this PR we do not expect any functional changes, only adding the ability to use AsideHeader in a different way

@DarkGenius
Copy link
Collaborator

Please add to README example of use PageLayout

package.json Outdated Show resolved Hide resolved
Copy link
Collaborator

@DarkGenius DarkGenius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PageLayout and PageLayoutAside components are directly related to AsideHeader. Let's move them to AsideHeader/components.

@ldrv565 ldrv565 requested a review from DarkGenius November 2, 2023 15:55
@gravity-ui-bot
Copy link
Contributor

Preview is ready.

@DarkGenius DarkGenius merged commit 1099f68 into gravity-ui:main Nov 3, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants