Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(MenuItem): extend tooltipText prop #133

Merged
merged 1 commit into from
Oct 10, 2023
Merged

feat(MenuItem): extend tooltipText prop #133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/components/AsideHeader/__stories__/AsideHeaderShowcase.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
const openModalCount = data?.meta?.layers?.filter(
({type}) => type === 'modal',
).length;
callback(openModalCount !== 0);

Check warning on line 53 in src/components/AsideHeader/__stories__/AsideHeaderShowcase.tsx

View workflow job for this annotation

GitHub Actions / Verify Files 

Expected return with your callback function
}
});
};
Expand Down Expand Up @@ -129,7 +129,7 @@
compact={compact}
multipleTooltip={multipleTooltip}
openModalSubscriber={openModalSubscriber}
renderFooter={({compact, asideRef}) => (

Check warning on line 132 in src/components/AsideHeader/__stories__/AsideHeaderShowcase.tsx

View workflow job for this annotation

GitHub Actions / Verify Files 

'compact' is already declared in the upper scope
<React.Fragment>
<FooterItem
compact={compact}
Expand Down Expand Up @@ -173,7 +173,11 @@
id: 'project-settings',
icon: Gear,
title: 'Settings with panel',
tooltipText: 'Settings with panel',
tooltipText: (
<div>
<b>Settings with panel</b>
</div>
),
current: visiblePanel === Panel.ProjectSettings,
onItemClick: () => {
setVisiblePanel(
Expand Down
2 changes: 1 addition & 1 deletion src/components/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export interface MakeItemParams {
export interface MenuItem {
id: string;
title: React.ReactNode;
tooltipText?: string;
tooltipText?: React.ReactNode;
icon?: IconProps['data'];
iconSize?: number | string;
link?: string;
Expand Down
Loading