Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: always export utility variables in themer #252

Merged
merged 1 commit into from
Aug 8, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions src/components/Themes/lib/themeCreatorExport.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
createUtilityColorCssVariable,
isPrivateColorToken,
} from './themeCreatorUtils';
import type {ColorOption, ThemeCreatorState, ThemeVariant} from './types';
import type {ThemeCreatorState, ThemeVariant} from './types';

const COMMON_VARIABLES_TEMPLATE_NAME = '%COMMON_VARIABLES%';
const LIGHT_THEME_VARIABLES_TEMPLATE_NAME = '%LIGHT_THEME_VARIABLES%';
Expand Down Expand Up @@ -94,7 +94,7 @@
}

if (paletteTokens[token]?.privateColors[themeVariant]) {
Object.entries(paletteTokens[token].privateColors[themeVariant]!).forEach(

Check warning on line 97 in src/components/Themes/lib/themeCreatorExport.ts

View workflow job for this annotation

GitHub Actions / Verify Files

Forbidden non-null assertion
([privateColorCode, color]) => {
privateColors[createPrivateColorToken(token, privateColorCode)] = color;
cssVariables += `${createPrivateColorCssVariable(
Expand All @@ -115,14 +115,6 @@

Object.entries(themeState.colors[themeVariant]).forEach(
([colorName, colorOrPrivateToken]) => {
if (
ignoreDefaultValues &&
DEFAULT_THEME.colors[themeVariant][colorName as ColorOption] ===
colorOrPrivateToken
) {
return;
}

const color = isPrivateColorToken(colorOrPrivateToken)
? `var(${createPrivateColorCssVariableFromToken(colorOrPrivateToken)})`
: colorOrPrivateToken;
Expand Down
Loading