Feat/create theme preview section #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arucard89
reviewed
Jul 2, 2024
| } | ||
|
|
||
| const PreviewLayout = ({breadCrumbsItems, children, styles, id}: PreviewLayoutProps) => { | ||
| const [theme, setTheme] = useState<'light' | 'dark'>('dark'); |
There was a problem hiding this comment.
может быть, тут стоит использовать тип ThemeType из uikit?
upd: возможно, даже, Theme
Arucard89
reviewed
Jul 2, 2024
| import './PreviewTab.scss'; | ||
| import {TablePreview} from './TablePreview/TablePreview'; | ||
|
|
||
| export const b = block('themes-preview'); |
There was a problem hiding this comment.
возможно, стоит назвать блок themes-preview-layout поскольку далее по коду везде использование имени блока начинается со слова layout : b('layout.... мне кажется, так будет больше подходить под БЭМ?
bityutskiyAO
force-pushed
the
feat/create-theme-preview-section
branch
from
6b2e79e to
7c76fac
Compare
dgaponov
pushed a commit
that referenced
this pull request
Aug 7, 2024
* feat: add theme export to Preview tab * feat: add table and form preview * feat: add card preview component * feat: add dashboard preview * fix: loader color * fix issues * fix typos
dgaponov
pushed a commit
that referenced
this pull request
Aug 7, 2024
* feat: add theme export to Preview tab * feat: add table and form preview * feat: add card preview component * feat: add dashboard preview * fix: loader color * fix issues * fix typos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.