feat: base structure of theme creator #212
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgaponov
commented
Jun 10, 2024
amje
requested changes
Jun 10, 2024
src/components/Theme/ColorsTab/BasicPalette/ThemePaletteCard.tsx
Outdated
Show resolved
Hide resolved
Comment on lines
6
to
7
| --g-button-border-radius: var(--g-spacing-2); | ||
| --g-text-input-border-radius: var(--g-spacing-2); |
There was a problem hiding this comment.
Using spacing size for border-radius seems wrong
|
|
||
| &__theme-root { | ||
| --g-color-base-background: transparent; | ||
| --g-button-border-radius: var(--g-spacing-2); |
bityutskiyAO
requested changes
Jun 11, 2024
| <Text variant="subheader-3" className={b('title')}> | ||
| Support Colors for various cases and | ||
| <br /> states | ||
| </Text> |
There was a problem hiding this comment.
will u add localization?
dgaponov
force-pushed
the
feat/theme-creator
branch
from
9e96fae to
96c3f44
Compare
dgaponov
force-pushed
the
feat/theme-creator
branch
from
0ba8dbe to
9415af5
Compare
dgaponov
force-pushed
the
feat/theme-creator
branch
from
9415af5 to
08e3b8c
Compare
|
I'm closing this PR. All changes were merged into the PR #216. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.