Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add github stars promotion block #207

Merged
merged 9 commits into from
May 24, 2024
Merged

feat: add github stars promotion block #207

merged 9 commits into from
May 24, 2024

Conversation

shbov
Copy link
Contributor

@shbov shbov commented May 23, 2024

DATAUI-2207

@shbov shbov marked this pull request as ready for review May 23, 2024 16:15
@shbov shbov requested a review from imsitnikov as a code owner May 23, 2024 16:15
animation-delay: 500ms;
}

@media (max-width: map-get(pcVariables.$gridBreakpoints, 'sm') - 1) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's remove this block?

}}
/>
<>
<GithubStarsBlock device="desktop" />
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's hide this block for rtl landing or adapt it for rtl.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed both comments

@shbov shbov merged commit e86d24e into main May 24, 2024
1 check passed
@shbov shbov deleted the shbovv/add_github_stars branch May 24, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants