Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add aria-label for overlay dropdown #228

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/components/OverlayControls/OverlayControls.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -331,6 +331,7 @@ class OverlayControls extends React.Component<OverlayControlsProps> {
view={view}
size={size}
pin={isOnlyOneItem ? 'round-round' : 'brick-round'}
extraProps={{'aria-label': i18n('label_more-options')}}
qa="dashkit-overlay-control-menu"
>
<Icon data={Ellipsis} size={OVERLAY_ICON_SIZE} />
Expand Down
1 change: 1 addition & 0 deletions src/i18n/en.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
"button_retry": "Repeat",
"label_render-markdown-error": "Ошибка преобразования в markdown",
"label_settings": "Settings",
"label_more-options": "More settings",
Copy link
Collaborator

@flops flops Dec 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've asked tech writer for help with texts and they've suggested "Additional options" and for russian "Дополнительные опции"

"label_copy": "Copy",
"label_delete": "Delete",
"label_error": "Error"
Expand Down
1 change: 1 addition & 0 deletions src/i18n/ru.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
"button_retry": "Повторить",
"label_render-markdown-error": "Ошибка преобразования в markdown",
"label_settings": "Настройки",
"label_more-options": "Больше опций",
"label_copy": "Копировать",
"label_delete": "Удалить",
"label_error": "Ошибка"
Expand Down
Loading