feat: delete grid item animation (#91)

gravity-ui · Oct 16, 2023 · b76b221 · b76b221
1 parent 815fff7
commit b76b221
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 21 deletions.
diff --git a/src/components/DashKit/DashKit.tsx b/src/components/DashKit/DashKit.tsx
@@ -33,8 +33,6 @@ interface DashKitDefaultProps {
     settings: SettingsProps;
     context: ContextProps;
     noOverlay: boolean;
-    // it will be deleted soon
-    _experimentDisableItemAnimation: boolean;
 }
 
 export interface DashKitProps extends DashKitGeneralProps, Partial<DashKitDefaultProps> {}
@@ -56,7 +54,6 @@ export class DashKit extends React.PureComponent<DashKitInnerProps> {
         },
         context: {},
         noOverlay: false,
-        _experimentDisableItemAnimation: false,
     };
 
     static registerPlugins(...plugins: Plugin[]) {

diff --git a/src/components/GridItem/GridItem.js b/src/components/GridItem/GridItem.js
@@ -75,7 +75,7 @@ class GridItem extends React.PureComponent {
             noOverlay,
             withCustomHandle,
         } = this.props;
-        const {editMode, _experimentDisableItemAnimation} = this.context;
+        const {editMode} = this.context;
         const width = Number.parseInt(style.width, 10);
         const height = Number.parseInt(style.height, 10);
         const transform = style.transform;
@@ -93,7 +93,6 @@ class GridItem extends React.PureComponent {
                     {
                         'is-dragging': isDragging,
                         'with-custom-handle': withCustomHandle,
-                        'disable-animation': _experimentDisableItemAnimation,
                     },
                     preparedClassName,
                 )}

diff --git a/src/components/GridItem/GridItem.scss b/src/components/GridItem/GridItem.scss
@@ -1,11 +1,6 @@
 .dashkit-grid-item {
     position: relative;
 
-    &_is-dragging {
-        // https://github.com/STRML/react-grid-layout/issues/221#issuecomment-519844166
-        //user-select: none;
-    }
-
     &__overlay {
         position: absolute;
         top: 0;
@@ -38,15 +33,6 @@
     transition: height 200ms ease;
 }
 
-.react-grid-item {
-    transition: all 200ms ease;
-    transition-property: left, top;
-
-    &.dashkit-grid-item_disable-animation {
-        transition: none;
-    }
-}
-
 .react-grid-item.cssTransforms {
     transition-property: transform;
 }

diff --git a/src/hocs/withContext.js b/src/hocs/withContext.js
@@ -198,7 +198,6 @@ function useMemoStateContext(props) {
             revertToOriginalLayout,
             forwardedMetaRef: props.forwardedMetaRef,
             draggableHandleClassName: props.draggableHandleClassName,
-            _experimentDisableItemAnimation: props._experimentDisableItemAnimation,
         }),
         [
             resultLayout,
@@ -221,7 +220,6 @@ function useMemoStateContext(props) {
             revertToOriginalLayout,
             props.forwardedMetaRef,
             props.draggableHandleClassName,
-            props._experimentDisableItemAnimation,
         ],
     );
 }