Remove remaining db and discovery AWS SDK imports #51628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GavinFrazar
added
the
no-changelog
GavinFrazar
force-pushed
the
gavinfrazar/simplify-aws-sigv4-signing-utils-pkg
branch
from
f1aca30 to
b223177
Compare
GavinFrazar
force-pushed
the
gavinfrazar/final-sdk-migrations
branch
2 times, most recently
from
75f0212 to
c4c78e8
Compare
github-actions
bot
added
database-access
rosstimothy
approved these changes
Jan 30, 2025
kimlisa
approved these changes
Jan 30, 2025
public-teleport-github-review-bot
bot
removed the request for review
from greedy52
greedy52
reviewed
Jan 30, 2025
greedy52
approved these changes
Jan 30, 2025
GavinFrazar
force-pushed
the
gavinfrazar/simplify-aws-sigv4-signing-utils-pkg
branch
from
b223177 to
71ea35e
Compare
Base automatically changed from
gavinfrazar/simplify-aws-sigv4-signing-utils-pkg
to
master
January 30, 2025 20:34
GavinFrazar
force-pushed
the
gavinfrazar/final-sdk-migrations
branch
3 times, most recently
from
2eb0b50 to
01a7573
Compare
This eliminates all remaining references to AWS SDK v1 in the lib/srv/db/... and lib/srv/discovery/... packages. Most of the changes are simply to remove dead code.
GavinFrazar
force-pushed
the
gavinfrazar/final-sdk-migrations
branch
from
01a7573 to
2465422
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This eliminates all remaining references to AWS SDK v1 in the lib/srv/db/... and lib/srv/discovery/... packages. Most of the changes are simply to remove dead code.
This PR depends on and is stacked on top of another PR:
Part of #14142