Add Role Diff Visual to Role editor #51483
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will enable a role diff viewer from Teleport Policy if the client has Teleport policy enabled
avatus
added
the
no-changelog
ryanclark
reviewed
Jan 25, 2025
| @@ -50,8 +50,9 @@ import { State, useRoles } from './useRoles'; | |||
|
|
|||
| // RoleDiffProps are an optional set of props to render the role diff visualizer. | |||
| type RoleDiffProps = { | |||
| RoleDiffComponent: ComponentType; | |||
| updateRoleDiff: (role: Role) => Promise<void>; | |||
| RoleDiffComponent: React.ReactElement; | |||
There was a problem hiding this comment.
As this is now an element, normally the prop doesn't start with a capital letter
For example, react-error-boundary's props
(Also I think this should be a ReactNode - react-error-boundary and React.PropsWithChildren use ReactNode)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will enable a role diff viewer from Teleport Policy if the client has Teleport policy enabled
Screen.Recording.2025-01-24.at.4.31.23.PM.mov
TODO
Add a few more tests, however, most of the work is from the Diff component which we get pulled in from "over the wire" from TAG so, testing won't work too well there. There are already tests added to test the RoleDiffComponent and role editor conditional rendering so this PR is mostly just using existing work.