Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump helm/kind-action from 1.9.0 to 1.12.0 in /.github/workflows #51254

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 20, 2025

Bumps helm/kind-action from 1.9.0 to 1.12.0.

Release notes

Sourced from helm/kind-action's releases.

v1.12.0

What's Changed

New Contributors

Full Changelog: helm/kind-action@v1.11.0...v1.12.0

v1.11.0

What's Changed

New Contributors

Full Changelog: helm/kind-action@v1.10.0...v1.11.0

v1.10.0

Requirements

We changed to use wget instead of curl

What's Changed

Full Changelog: helm/kind-action@v1.9.0...v1.10.0

Commits
  • a1b0e39 Bump actions/checkout from 4.1.4 to 4.2.2 in the actions group (#130)
  • 9315f6b feat: options to configure local registry (#113)
  • aed9fb9 update kind to use release v0.26.0 (#129)
  • ae94020 update kind to default to release v0.24.0 (#122)
  • 9fdad06 fix: Use new mirror for downloading kubectl (#127)
  • c93960c Bump actions/checkout from 4.2.1 to 4.2.2 in the actions group (#125)
  • fce224d Bump actions/checkout from 4.2.0 to 4.2.1 in the actions group (#123)
  • 0958ddc Bump actions/checkout from 4.1.7 to 4.2.0 in the actions group (#121)
  • 5d66646 feat: add custom kubeconfig option as action input (#119)
  • 6f17223 Bump actions/checkout from 4.1.7 to 4.2.0 in the actions group (#120)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Jan 20, 2025
@dependabot dependabot bot requested a review from tcsc as a code owner January 20, 2025 20:47
@dependabot dependabot bot requested a review from rosstimothy as a code owner January 20, 2025 20:47
@dependabot dependabot bot added the no-changelog Indicates that a PR does not require a changelog entry label Jan 20, 2025
@dependabot dependabot bot requested a review from codingllama as a code owner January 20, 2025 20:47
@codingllama codingllama enabled auto-merge January 21, 2025 14:01
Bumps [helm/kind-action](https://github.com/helm/kind-action) from 1.9.0 to 1.12.0.
- [Release notes](https://github.com/helm/kind-action/releases)
- [Commits](helm/kind-action@99576bf...a1b0e39)

---
updated-dependencies:
- dependency-name: helm/kind-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/github_actions/dot-github/workflows/helm/kind-action-1.12.0 branch from ea24667 to 435f8cd Compare January 21, 2025 14:36
@codingllama codingllama added this pull request to the merge queue Jan 22, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 22, 2025
@camscale camscale added this pull request to the merge queue Jan 22, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 22, 2025
@camscale camscale added this pull request to the merge queue Jan 22, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 22, 2025
@codingllama codingllama added this pull request to the merge queue Jan 22, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 22, 2025
@codingllama codingllama added this pull request to the merge queue Jan 22, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 22, 2025
@codingllama codingllama added this pull request to the merge queue Jan 22, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 22, 2025
@codingllama
Copy link
Contributor

I'm starting to think all those flakes aren't actually flakes... 😊

@tigrato could you take a look, please?

@tigrato tigrato added this pull request to the merge queue Jan 22, 2025
@codingllama
Copy link
Contributor

Thanks, Tiago!

@tigrato tigrato removed this pull request from the merge queue due to a manual request Jan 22, 2025
@tigrato tigrato force-pushed the dependabot/github_actions/dot-github/workflows/helm/kind-action-1.12.0 branch from a1b9e2b to 7074bcb Compare January 22, 2025 16:46
@tigrato tigrato enabled auto-merge January 22, 2025 16:47
@tigrato tigrato added this pull request to the merge queue Jan 22, 2025
@tigrato tigrato removed this pull request from the merge queue due to a manual request Jan 22, 2025
@tigrato
Copy link
Contributor

tigrato commented Jan 23, 2025

Pending on #51398 being merged.

@tigrato tigrato force-pushed the dependabot/github_actions/dot-github/workflows/helm/kind-action-1.12.0 branch from 7074bcb to 435f8cd Compare January 23, 2025 11:01
@codingllama
Copy link
Contributor

@tigrato could you give us some background on what is wrong here and why #51398 helps?

@tigrato
Copy link
Contributor

tigrato commented Jan 23, 2025

@tigrato could you give us some background on what is wrong here and why #51398 helps?

Sure.

The kind actions upgrade also updates the Kubernetes version from 1.27.x to 1.32.x. Starting with Kubernetes 1.30, the default exec protocol was switched from the deprecated SPDY protocol to websockets.

The behavior of the WebSocket executor differs from the SPDY executor when the upstream connection is terminated. Websocket returns an error, while the other simply terminates without returning an error.

With the upgrade to Kubernetes 1.32, Teleport began using websockets, causing all errors to be returned when we tested the monitor blocking the connection. Unfortunately, Kubernetes did not properly wrap the error, instead returning fmt.Errorf("... %s", err), which prevented us from using errors.Is/As to identify the error. Raised kubernetes/kubernetes#129765

Tired of dealing with err strings partial checks, I partially addressed the issue in #18496 by returning a proper error message.

Now, the server provides a proper reason to the client, clearly indicating why the connection was terminated.

Updating the action here is now correct because we always expect an error from #51398

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file github-actions no-changelog Indicates that a PR does not require a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants