-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improving regular SSH port forwarding audit logs #50932
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avatus
approved these changes
Jan 10, 2025
rosstimothy
reviewed
Jan 10, 2025
EdwardDowling
approved these changes
Jan 10, 2025
eriktate
force-pushed
the
eriktate/ssh-port-forwarding-audit-logs
branch
from
January 14, 2025 02:39
ef0154f
to
f51fada
Compare
It looks like the events are now being emitted in the right places, though I'm seeing a few things that still need to be addressed. The logs are spewing the following when emitting events:
The web ui is unable to render the forwarding events: |
eriktate
force-pushed
the
eriktate/ssh-port-forwarding-audit-logs
branch
5 times, most recently
from
January 15, 2025 21:22
3d0ccd6
to
fbb1383
Compare
rosstimothy
reviewed
Jan 16, 2025
Can you please update the PR title and description to reflect that this is not updating events emitted by the forwarding server and that will happen in the future? |
eriktate
force-pushed
the
eriktate/ssh-port-forwarding-audit-logs
branch
from
January 16, 2025 16:58
16d5cf4
to
94fefc5
Compare
eriktate
changed the title
Improving SSH port forwarding audit logs
Improving regular SSH port forwarding audit logs
Jan 16, 2025
eriktate
force-pushed
the
eriktate/ssh-port-forwarding-audit-logs
branch
4 times, most recently
from
January 16, 2025 18:03
7dad152
to
048518e
Compare
rosstimothy
approved these changes
Jan 16, 2025
eriktate
force-pushed
the
eriktate/ssh-port-forwarding-audit-logs
branch
from
January 16, 2025 23:10
835ec45
to
bf6fcae
Compare
mvbrock
pushed a commit
that referenced
this pull request
Jan 18, 2025
This was referenced Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
audit-log
Issues related to Teleports Audit Log
backport/branch/v15
backport/branch/v16
backport/branch/v17
size/md
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR emits some additional events for SSH port forwarding and adds some context around local/remote when possible. The emitted events should look like the following:
Remote and local port forwarding for the forward SSH server log an event for everything, but the session-level events do not differentiate between remote/local.There are some small issues with properly capturing event data for the forward server, so I've not included the new events in this PR. I plan on addressing this in a follow upEvery event should contain the remote, local, and target address where applicable. For remote forwarding, session-level events will show the requester as the remote address whereas connection-level events should show the client address initiating the connection.
changelog: Added more granular audit logging surrounding SSH port forwarding