Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix useMfa error handling #50844

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Joerger
Copy link
Contributor

@Joerger Joerger commented Jan 7, 2025

The original error is now displayed in the MFA dialog, and the MFA canclled by user error is displayed at the top level after the MFA dialog is closed:

Screenshot 2025-01-07 at 12 22 32 PM
Screenshot 2025-01-07 at 12 23 37 PM

Fixes #50582

This will be backported with #50529

@Joerger Joerger added no-changelog Indicates that a PR does not require a changelog entry backport/branch/v17 labels Jan 7, 2025
@github-actions github-actions bot requested review from kimlisa and kiosion January 7, 2025 20:25
@Joerger Joerger requested a review from gzdunek January 7, 2025 20:26
@Joerger
Copy link
Contributor Author

Joerger commented Jan 7, 2025

@gzdunek This is the same issue you pointed out here. I just separated the fix 93ec6b7 into this new PR, in case #50373 is scrapped.

@zmb3
Copy link
Collaborator

zmb3 commented Jan 8, 2025

Can we use the American-English spelling (canceled) instead of the British-English spelling (cancelled)?

@Joerger Joerger force-pushed the joerger/fix-useMfa-error-state branch from 01d553d to dd33f6a Compare January 8, 2025 17:47
@Joerger Joerger force-pushed the joerger/fix-useMfa-error-state branch from dd33f6a to 6de6710 Compare January 8, 2025 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/branch/v17 no-changelog Indicates that a PR does not require a changelog entry size/sm ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

web: canceling MFA dialog shows same error twice
2 participants