Convert logging in build.assets/tooling to use slog #50805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosstimothy
force-pushed
the
tross/build.assets_slog
branch
4 times, most recently
from
e6ad66a to
d4bf503
Compare
rosstimothy
changed the base branch from
master
to
tross/remove_notarize_binaries
rosstimothy
added
the
no-changelog
marcoandredinis
approved these changes
Jan 8, 2025
rosstimothy
force-pushed
the
tross/build.assets_slog
branch
from
d4bf503 to
4d305f9
Compare
Merged
codingllama
approved these changes
Jan 8, 2025
| ) | ||
|
|
||
| const pluginInputPathEnvironment = "TELEPORT_PROTOC_READ_FILE" | ||
|
|
||
| func readRequest() (*plugin.CodeGeneratorRequest, error) { | ||
| inputPath := os.Getenv(pluginInputPathEnvironment) | ||
| if inputPath == "" { | ||
| log.Error(trace.BadParameter("When built with the 'debug' tag, the input path must be set through the environment variable: %s", pluginInputPathEnvironment)) | ||
| slog.ErrorContext(context.Background(), "When built with the 'debug' tag, the input path must be set through the TELEPORT_PROTOC_READ_FILE environment variable") |
There was a problem hiding this comment.
Maybe:
Suggested change
| slog.ErrorContext(context.Background(), "When built with the 'debug' tag, the input path must be set through the TELEPORT_PROTOC_READ_FILE environment variable") | |
| const message = "When built with the 'debug' tag, the input path must be set through the " + pluginInputPathEnvironment + " environment variable" | |
| slog.ErrorContext(context.Background(), message) |
public-teleport-github-review-bot
bot
removed request for
strideynet and
Joerger
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.