[v17] fix: allow CredentialCache.Retrieve to return before initialization #50790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #50747 This PR adds an option to allow CredentialsCache.Retrieve to return with an error before CredentialsCache.SetGenerateOIDCTokenFn has been called. We have been relying on this behaviour for Auth service startup, because the credential cache is a dependency for the audit storage, which is a dependency for the auth server, which is a dependency for the credential cache's GenerateOIDCTokenFn. Some non-critical checks during auth startup must fail instead of hanging on blocking the process from successfully starting.
github-actions
bot
added
audit-log
nklaassen
added
the
no-changelog
rosstimothy
approved these changes
Jan 6, 2025
Joerger
approved these changes
Jan 6, 2025
public-teleport-github-review-bot
bot
removed request for
tigrato and
smallinsky
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #50748 to branch/v17