[v17] DiscoveryConfigStatus: update even when no resource is found #50766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoandredinis
added
the
no-changelog
marcoandredinis
force-pushed
the
marco/v17/backport_50433
branch
from
a216f39 to
4e89680
Compare
* DiscoveryConfigStatus: update even when no resource is found During Auto Discover, when using a DiscoveryConfig, if no resources are found, the DiscoveryConfigStatus is not updated accordingly. This PR ensures that, even when no resources are found, the status will report so. * use comparable instead of any for generic method * remove useless un-named function on PreFetchHooks * prevent call to ssm:SendCommand with 0 instances * rename var from ok to found
marcoandredinis
force-pushed
the
marco/v17/backport_50433
branch
from
4e89680 to
ce37330
Compare
espadolini
approved these changes
Jan 7, 2025
tigrato
approved these changes
Jan 7, 2025
public-teleport-github-review-bot
bot
removed the request for review
from Joerger
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #50433 to v17