Fix tempdir failure in TestInitDatabaseService #50717
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test was setting the auth's storage config to use a different temp dir than the backend's storage dir, which could result in the non-empty directory that fails during cleanup. As of #48247 tests don't need to set this at all since the default behavior now does the right thing.
zmb3
added
no-changelog
strideynet
approved these changes
Jan 3, 2025
rosstimothy
approved these changes
Jan 3, 2025
public-teleport-github-review-bot
bot
removed the request for review
from greedy52
|
@rosstimothy exclude flake for me? |
|
/excludeflake * |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting auth's
DataDirtot.TempDir()and then setting the storage config path to at.TempDir()ends up creating two totally separate temporary directories, and the behavior that Teleport generally expects is that the auth audit storage is a subdirectory of auth's data dir.Since #48247 merged it is no longer necessary to set the audit storage at all, the default behavior will be to put it in a subdirectory of the data dir.