Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update Policy and Graph Explorer verbiage in teleport-policy guide #50412

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mmcallister
Copy link
Contributor

For update request via #50411.
Changes made in the admin-guides/teleport-policy pages; I'll go through the rest of the doc and update as well if these edits look ok.

cc @roraback

Copy link

🤖 Vercel preview here: https://docs-i54z7vtx4-goteleport.vercel.app/docs

@@ -95,16 +94,16 @@ it's possible to reuse it as long as the following requirements are met:

- On step 2, you match the `discovery_group` with the existing Discovery Service's
`discovery_group`.
- Access Graph service is reachable from the machine where Discovery Service runs.
- Graph Explorer service is reachable from the machine where Discovery Service runs.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of this is good, but I would note again that we run the access graph service for this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you suggest a different way to phrase this? The req for this was to change 'access graph' to Graph Explorer since that's what it is now called in the UI. I think you are saying access graph is what is powering Explorer, but I don't want to confused users.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@benarent when you have a moment can you give this another look?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the menu we call it Graph Explorer, but we do still reference Access Graph. image

Copy link

github-actions bot commented Jan 10, 2025

Amplify deployment status

Branch Commit Job ID Status Preview Updated (UTC)
policy-and-graph-changes HEAD 1 ✅SUCCEED policy-and-graph-changes 2025-01-10 03:10:05

@mmcallister mmcallister marked this pull request as ready for review January 13, 2025 22:29
@mmcallister mmcallister added no-changelog Indicates that a PR does not require a changelog entry backport/branch/v16 backport/branch/v17 and removed size/sm labels Jan 13, 2025
@mmcallister mmcallister self-assigned this Jan 13, 2025
@mmcallister mmcallister requested a review from benarent January 14, 2025 17:59
@mmcallister mmcallister enabled auto-merge January 15, 2025 20:54
@mmcallister mmcallister marked this pull request as draft January 17, 2025 21:29
auto-merge was automatically disabled January 17, 2025 21:29

Pull request was converted to draft

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/branch/v16 backport/branch/v17 documentation no-changelog Indicates that a PR does not require a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: update Policy and Graph Explorer verbiage
2 participants