-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add uri flag for s3 path style addressing configuration #49835
base: master
Are you sure you want to change the base?
Conversation
This change looks good to me, but should probably have the storage backend doc reflect the change: https://github.com/gravitational/teleport/blob/master/docs/pages/reference/backends.mdx#s3-session-recordings I think we'd only need to add this bullet point underneath the
I'm happy to add this doc commit to the branch for this PR if it's helpful. |
Added it in there |
Amplify deployment status
|
@hugoShaka @tcsc Can you take a look at this when you get a chance |
Can we do a real-world test against an s3 backend not supporting path-style adressing and see if we can make teleport work? Or maybe send a dev build to the affected customer? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm after you fix the docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make sure to retest everything again since we've inverted the flag here and if everything is ok let's ship it.
5a4f54a
to
aabc379
Compare
Add ability to disable path-style S3 access for third-party endpoints.
part of: #48451
Fixes https://github.com/gravitational/customer-sensitive-requests/issues/346
changelog: Add ability to disable path-style S3 access for third-party endpoints.