Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub proxy part 4.5: git server in UI #49644

Merged
merged 4 commits into from
Jan 21, 2025
Merged

GitHub proxy part 4.5: git server in UI #49644

merged 4 commits into from
Jan 21, 2025

Conversation

greedy52
Copy link
Contributor

@greedy52 greedy52 commented Dec 2, 2024 •
edited
Loading

Related:

e:

(note, this PR is optional for the initial MVP release but very nice to have)

Storybook screenshots:
Screenshot 2024-12-02 at 11 06 09 AM
Screenshot 2024-12-02 at 11 06 30 AM

@greedy52 greedy52 added no-changelog Indicates that a PR does not require a changelog entry backport/branch/v17 labels Dec 2, 2024
@greedy52 greedy52 self-assigned this Dec 2, 2024
@greedy52 greedy52 mentioned this pull request Dec 2, 2024
Closed
9 tasks
@greedy52 greedy52 force-pushed the STeve/48762_git_server_cache_unified_resource branch from d1e8553 to 982bf3d Compare December 5, 2024 03:55
Base automatically changed from STeve/48762_git_server_cache_unified_resource to master December 5, 2024 17:58
@greedy52 greedy52 force-pushed the STeve/48762_git_server_cache_unified_resource_ui branch 7 times, most recently from fb9aeb1 to acaca65 Compare December 8, 2024 03:37
@greedy52 greedy52 requested a review from avatus December 9, 2024 14:35
@greedy52 greedy52 marked this pull request as ready for review December 9, 2024 14:35
@github-actions github-actions bot requested a review from gzdunek December 9, 2024 14:36
@avatus
Copy link
Contributor

avatus commented Dec 9, 2024

I didn't get a chance to check this out today but i will look at it the first thing in the morning tomorrow

gzdunek
gzdunek reviewed Dec 10, 2024
View reviewed changes
web/packages/shared/components/UnifiedResources/types.ts Outdated Show resolved Hide resolved
web/packages/teleport/src/GitServers/ConnectDialog/ConnectDialog.tsx Outdated Show resolved Hide resolved
web/packages/teleport/src/GitServers/ConnectDialog/ConnectDialog.tsx Outdated Show resolved Hide resolved
web/packages/teleport/src/GitServers/ConnectDialog/ConnectDialog.tsx Outdated Show resolved Hide resolved
web/packages/teleport/src/UnifiedResources/ResourceActionButton.tsx Outdated Show resolved Hide resolved
web/packages/teleport/src/GitServers/ConnectDialog/ConnectDialog.tsx Outdated Show resolved Hide resolved
web/packages/teleport/src/GitServers/ConnectDialog/ConnectDialog.tsx Outdated Show resolved Hide resolved
web/packages/teleport/src/GitServers/ConnectDialog/ConnectDialog.tsx Outdated Show resolved Hide resolved
web/packages/teleport/src/UnifiedResources/ResourceActionButton.tsx Outdated
Comment on lines 338 to 340
const organization = gitserver.github
? gitserver.github.organization
: undefined;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const organization = gitserver.github
? gitserver.github.organization
: undefined;
const organization = gitserver.github?.organization;

web/packages/teleport/src/services/agents/types.ts Outdated Show resolved Hide resolved
avatus
avatus reviewed Dec 10, 2024
View reviewed changes
lib/web/ui/server.go Outdated Show resolved Hide resolved
@greedy52 greedy52 force-pushed the STeve/48762_git_server_cache_unified_resource_ui branch from acaca65 to 8cf6b5a Compare January 20, 2025 14:23
@greedy52 greedy52 requested review from gzdunek and avatus January 20, 2025 14:34
@greedy52
Copy link
Contributor Author

@avatus @gzdunek sorry for the delay. i had to prioritize other tasks for this feature since this part is optional. I've rebased the branch and applied review comments. 🙏

gzdunek
gzdunek approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@gzdunek gzdunek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

web/packages/teleport/src/GitServers/ConnectDialog.tsx Outdated Show resolved Hide resolved
@greedy52 greedy52 enabled auto-merge January 21, 2025 16:19
@greedy52 greedy52 added this pull request to the merge queue Jan 21, 2025
Merged via the queue into master with commit 6e0177e Jan 21, 2025
45 checks passed
@greedy52 greedy52 deleted the STeve/48762_git_server_cache_unified_resource_ui branch January 21, 2025 18:32
@public-teleport-github-review-bot
Copy link

@greedy52 See the table below for backport results.

Branch Result
branch/v17 Create PR

@greedy52 greedy52 mentioned this pull request Jan 21, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gzdunek gzdunek gzdunek approved these changes

@avatus avatus avatus approved these changes

Assignees

@greedy52 greedy52

Labels
backport/branch/v17 no-changelog Indicates that a PR does not require a changelog entry size/md ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@greedy52 @avatus @gzdunek